const2bit: avoid heap allocations #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will revise the commit message to align with the others, so I'll mark it as a draft for now. The code is already complete, so it's fine to review it if you'd like. |
sago35
force-pushed
the
avoid-heap-allocs-const2bit
branch
from
b133511
to
5c0c89f
Compare
|
Now ready for review. |
deadprogram
reviewed
Oct 23, 2024
|
Thanks for the improvement @sago35 now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes heap allocation from
const2bit.It is considered safe since it essentially uses the same approach as #46.